Refactor handle_return #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have rescoped this PR to only refactor the handle_return part now, which has been done well. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the return statement handling functionality in a Python-to-BPF compiler by extracting return logic into separate utility modules and improving code organization.
Key changes:
- Extracted return handling logic from
functions_pass.pyinto dedicated utility modules - Enhanced expression evaluation to support binary operations and ctypes casting
- Added comprehensive test coverage for various return statement patterns
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pythonbpf/functions/return_utils.py |
New utility module containing extracted return handling functions |
pythonbpf/functions/functions_pass.py |
Refactored to use new return handling utilities and updated imports |
pythonbpf/functions/func_registry_handlers.py |
New registry pattern for statement handlers |
pythonbpf/expr_pass.py |
Enhanced with ctypes casting and binary operation support |
pythonbpf/type_deducer.py |
Reorganized code structure and added ctypes validation function |
pythonbpf/codegen.py |
Updated import path for functions module |
tests/passing_tests/return/*.py |
Added test files covering various return scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.